XPack helper for naming monitoring indices #7586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
commented
Jul 12, 2018
| // a given product { elasticsearch, kibana, logstash, beats } | ||
| func MakeMonitoringIndexName(product Product) string { | ||
| today := time.Now().UTC().Format("2006.01.02") | ||
| const version = "6" |
There was a problem hiding this comment.
Is there some way to look up metricbeat's major version at runtime? Then we can remove this hardcoding here. Otherwise we'll have to remember to update it manually every major release.
There was a problem hiding this comment.
It is part of the beat.Infotype but it's not global :-( Let's hard code it for now but add a TODO / note here.
ycombinator
commented
Jul 12, 2018
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. |
There was a problem hiding this comment.
Is this license (and the one in xpack.go) the right one to use?
39 tasks
ycombinator
force-pushed
the
xpack/monitoring/index-naming
branch
from
04f7c68
to
dfa6a18
Compare
ruflin
approved these changes
Jul 13, 2018
| // a given product { elasticsearch, kibana, logstash, beats } | ||
| func MakeMonitoringIndexName(product Product) string { | ||
| today := time.Now().UTC().Format("2006.01.02") | ||
| const version = "6" |
There was a problem hiding this comment.
It is part of the beat.Infotype but it's not global :-( Let's hard code it for now but add a TODO / note here.
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. |
ycombinator
added
needs_backport
ycombinator
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a helper method for generating monitoring index names for a given product (Elasticsearch, Kibana, etc.).