Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change priority order of reconcile results #2250

Merged

Conversation

charith-elastic
Copy link
Contributor

Changes the order of priority for reconcile results from noqueue < generic < specific to noqueue < specific < generic. See the issue for more information about the reasoning behind this change.

Fixes #2138

@charith-elastic charith-elastic added >bug Something isn't working v1.0.0 labels Dec 12, 2019
Copy link
Contributor

@david-kow david-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice tests 👍

@charith-elastic charith-elastic merged commit 2b404c3 into elastic:master Dec 13, 2019
@charith-elastic charith-elastic deleted the reconcile-result-priority branch December 13, 2019 15:06
mjmbischoff pushed a commit to mjmbischoff/cloud-on-k8s that referenced this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Something isn't working v1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic requeue result is ineffective
2 participants