Readiness probe: do not log tail errors #2366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it is not possible for the readiness script to log into
stderr
of PID 1.It is the case for example if the container is started with the
root
user:uid
ofpid
1 is changed to1000
by the startup script, hence the readiness script, which is running with the UID 0, is not able to write into/proc/1/fd/2
This is harmless but it generates the following message in the events:
Since the log redirection is done as a best effort this PR skips any error message from
tail
, this prevents the error to appear in theevents
of the Pod.Note that if the security context is correctly set (i.e. container is not running as
root
) this issue does not happen.credits goes to @david-kow