Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port to nodeSet headless service #3011

Merged
merged 1 commit into from
May 15, 2020

Conversation

charith-elastic
Copy link
Contributor

This is a tentative PR to add the Elasticsearch port to the headless service created for each node set. I have documented a couple of concerns regarding this change in the issue but I don't think they are egregious enough to avoid doing this completely.

Fixes #2843

@charith-elastic charith-elastic added the >enhancement Enhancement of existing functionality label Apr 29, 2020
Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebgl sebgl added the v1.2.0 label May 15, 2020
@charith-elastic charith-elastic merged commit dac3fcd into elastic:master May 15, 2020
@charith-elastic charith-elastic deleted the headless-svc-port branch May 15, 2020 13:59
@charith-elastic charith-elastic changed the title Add port to STS headless service Add port to nodeSet headless service Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality v1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add port to headless service
2 participants