Name transport service port #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyasabo
reviewed
Jun 12, 2020
| @@ -50,6 +50,7 @@ func NewTransportService(es esv1.Elasticsearch) *corev1.Service { | |||
| labels := label.NewLabels(nsn) | |||
| ports := []corev1.ServicePort{ | |||
| { | |||
| Name: "tls-transport", | |||
There was a problem hiding this comment.
A note for any other reviewers: istio requires it be prefixed with the protocol
anyasabo
previously approved these changes
Jun 12, 2020
thbkrkr
reviewed
Jun 12, 2020
| @@ -50,6 +50,7 @@ func NewTransportService(es esv1.Elasticsearch) *corev1.Service { | |||
| labels := label.NewLabels(nsn) | |||
| ports := []corev1.ServicePort{ | |||
| { | |||
| Name: "tls-transport", | |||
There was a problem hiding this comment.
This may deserve a little comment?
Suggested change
| Name: "tls-transport", | |
| Name: "tls-transport", // name the service with the protocol for Istio |
anyasabo
added
>enhancement
|
Added to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Names the port in the transport service so that it passes Istio checks.