Use eck-operator UBI image when ubiOnly=true.

[naemono]

resolves #7485

Ensure we use the -ubi operator image when ubiOnly is set to true.

❯ helm template eck-operator . -s templates/statefulset.yaml | yq '.spec.template.spec.containers[0].image'
docker.elastic.co/eck/eck-operator:2.12.0-SNAPSHOT

❯ helm template eck-operator . -s templates/statefulset.yaml --set=config.ubiOnly=true | yq '.spec.template.spec.containers[0].image'
docker.elastic.co/eck/eck-operator-ubi:2.12.0-SNAPSHOT

[thbkrkr]

We don't build -ubi snapshot of the operator image today (docker.elastic.co/eck/eck-operator-ubi:2.12.0-SNAPSHOT). We need to identify the type of trigger that requires the image and update BUILD_FLAVORS in the operator-image.sh script based on that.

Example if it is only for nightly main builds:

diff --git a/.buildkite/scripts/common/operator-image.sh b/.buildkite/scripts/common/operator-image.sh
index 64d62b073..4c4e81ba3 100644
--- a/.buildkite/scripts/common/operator-image.sh
+++ b/.buildkite/scripts/common/operator-image.sh
@@ -50,7 +50,8 @@ operator::set_build_flavors_var() {
     if [[ "${BUILD_FLAVORS:-}" == "" ]]; then
         case $trigger in
             tag-*)           BUILD_FLAVORS="eck,eck-dev,eck-fips,eck-ubi,eck-ubi-fips" ;;
-            *-main)          BUILD_FLAVORS="eck,eck-dev" ;;
+            merge-main)      BUILD_FLAVORS="eck,eck-dev" ;;
+            nightly-main)    BUILD_FLAVORS="eck,eck-dev,eck-ubi" ;;
             *-test-snapshot) BUILD_FLAVORS="eck,eck-dev" ;;
             pr-*|merge-xyz)  BUILD_FLAVORS="eck" ;;
             dev)             BUILD_FLAVORS="dev" ;;

[naemono]

We don't build -ubi snapshot of the operator image today (docker.elastic.co/eck/eck-operator-ubi:2.12.0-SNAPSHOT). We need to identify the type of trigger that requires the image and update BUILD_FLAVORS in the operator-image.sh script based on that.

Thank you. Upon looking through these options, I suspect nighty-main, tag-final, and tag-bc probably make the most sense, as we want to do this testing during BC iterations, after a release, and are discussing adding something in the nightly. I'll get these updated.

[naemono]

We don't build -ubi snapshot of the operator image today

This just happened to be me testing on a branch where snapshot was set, and no way was intended to mean that we should build these on for all SNAPSHOT builds...

[thbkrkr]

Code LGTM but are we okay with changing the existing behavior by forcing the use of the -ubi image when the Helm config.ubiOnly value is enabled?

[barkbay]

Let's maybe update the comment here if this setting does not only control the stack images:

cloud-on-k8s/deploy/eck-operator/values.yaml

Line 226 in 3ab46dd

# ubiOnly specifies whether the operator will use only UBI container images to deploy Elastic Stack applications. UBI images are only available from 7.10.0 onward.

Let's also create an issue so we don't forget to mention this change in the next release notes?

Other than that, I think I'm ok with this change, but @thbkrkr's comment is relevant, curious to know if there are other opinions.

[naemono]

Let's also create an issue so we don't forget to mention this change in the next release notes?

#7485 exists and is tagged with the next release. Is this what you were intending?

[barkbay]

#7485 exists and is tagged with the next release. Is this what you were intending?

Sorry, I meant an issue to maybe add a short sentence to mention this change in the highlights.

[naemono]

Sorry, I meant an issue to maybe add a short sentence to mention this change in the highlights.

I've added the release-highlight tag to that issue as well.

[barkbay]

I've added the release-highlight tag to that issue as well.

I have to confess that as a release manager I'm not sure I've ever used it 😬 . We should maybe update our release process.

[naemono]

I've added the release-highlight tag to that issue as well.

I have to confess that as a release manager I'm not sure I've ever used it 😬 . We should maybe update our release process.

I just updated the documentation/template mentioning this tag during writing of the release highlights.