-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eck-apm-server Helm Chart #7533
Conversation
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Update example configurations. Add basic example. Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it yet. Just read through the code. Looks good to me just a few small things.
deploy/eck-stack/charts/eck-apm-server/examples/jaeger-with-http-configuration.yaml
Outdated
Show resolved
Hide resolved
deploy/eck-stack/charts/eck-apm-server/templates/apmserver.yaml
Outdated
Show resolved
Hide resolved
deploy/eck-stack/charts/eck-apm-server/templates/apmserver.yaml
Outdated
Show resolved
Hide resolved
xpack.fleet.packages: | ||
- name: apm | ||
version: latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not mentioned in the APM docs (I know we added it as part of #6063) but I wonder why they don't mention it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll craft something and get our docs updated, since it seems to be required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was more thinking of the docs maintained by the APM team. But an update to our docs would be good too. Can be a separate PR from this one though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#7541 created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a look now.
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chart LGTM, only the doc thingy needs to go into another section IMO
docs/orchestrating-elastic-stack-applications/apm-server.asciidoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
closes #7489
What is this change?
This adds an ECK APM Server Helm Chart for deploying APM Server instances using the ECK Operator.
Testing
Simple install using basic.yaml and version 8.12.0 works fine:
Everything becomes healthy
All Components are green
Missing ES instance check works:
What isn't working?APM+Kibana integrationAPM+Fleet+Kibana testingTodo