-
Notifications
You must be signed in to change notification settings - Fork 600
[Rule Tuning] Updated ESQL Rules Based on Validation Results #5151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Enhancement - GuidelinesThese guidelines serve as a reminder set of considerations when addressing adding a new schema feature to the code. Documentation and Context
Code Standards and Practices
Testing
Additional Schema Related Checks
|
⛔️ Test failed Results
|
⛔️ Test failed Results
|
⛔️ Test failed Results
|
...integrations/okta/initial_access_okta_user_sessions_started_from_different_geolocations.toml
Outdated
Show resolved
Hide resolved
...ations/okta/credential_access_okta_authentication_for_multiple_users_from_single_source.toml
Outdated
Show resolved
Hide resolved
...redential_access_okta_authentication_for_multiple_users_with_the_same_device_token_hash.toml
Outdated
Show resolved
Hide resolved
...s/integrations/okta/credential_access_okta_multiple_device_token_hashes_for_single_user.toml
Outdated
Show resolved
Hide resolved
rules/integrations/aws/impact_aws_s3_bucket_enumeration_or_brute_force.toml
Show resolved
Hide resolved
…y logic to use LIKE instead of RLIKE
⛔️ Test failed Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see validation is working!
…inlogs* sightings to logs-azure.signinlogs-*
⛔️ Test failed Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅 Great work. Roughly 34% of our esql rules improved.
⛔️ Test failed Results
|
⛔️ Test failed Results
|
⛔️ Test failed Results
|
…'c07f7898-5dc3-11f0-9f27-f661ea17fbcd'
⛔️ Test failed Results
|
⛔️ Test failed Results
|
Note |
Addressed in 5ae9937 where we switched to load latest schemas which then pull this field and passes validation with no action needed here. |
⛔️ Test failed Results
|
⛔️ Test failed Results
|
Tested validation against all stack versions via updated code in a368516. > git checkout origin/update_esql_rules_from_validation -- detection_rules/etc/non-ecs-schema.json
> git checkout origin/update_esql_rules_from_validation -- rules
> python -m detection_rules dev test esql-remote-validation --verbosity 1
....
894b7cc9-040b-427c-aca5-36b40d3667bf: Validating 894b7cc9-040b-427c-aca5-36b40d3667bf against 9.2.0 stack
894b7cc9-040b-427c-aca5-36b40d3667bf: Validating 894b7cc9-040b-427c-aca5-36b40d3667bf against 8.18.0 stack
894b7cc9-040b-427c-aca5-36b40d3667bf: Validating 894b7cc9-040b-427c-aca5-36b40d3667bf against 8.19.0 stack
894b7cc9-040b-427c-aca5-36b40d3667bf: Validating 894b7cc9-040b-427c-aca5-36b40d3667bf against 9.0.0 stack
894b7cc9-040b-427c-aca5-36b40d3667bf: Validating 894b7cc9-040b-427c-aca5-36b40d3667bf against 9.1.0 stack
Total rules: 75
Failed rules: 0
Failed rules written to failed_rules.log No ESQL validation failures 🚀 Good to merge. |
Pull Request
Issue link(s):
Summary - What I changed
ESQL Rule Updates based on validation findings from #4955.
In addition to these fixes, there are 8 other rules with issues shown below that still need to be addressed. It would be great @terrancedejesus if you could take a look at these. Thanks!
Note: you can run
view-rule
with the esql remote validation flag to check any given rule individually using theesql-field-validation
branch from #4955.E.g.
How To Test
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist