[Bug] Order of same-product, multiple lifecycle applies_to statement is not correct

[theletterf]

I discovered this while adding the example in #2020.

See, for example, the Important note here: https://docs-v3-preview.elastic.dev/elastic/docs-builder/tree/main/syntax/admonitions#applies-to-information

The syntax is:

:applies_to: {"stack": "ga 9.2, preview 9.1", "serverless": "ga"}

So I guess it should show ga: 9.2 in the rendered pill, not the preview version. How is order determined?

[theletterf]

+CC @shainaraskas @florent-leborgne

[florent-leborgne]

Yes this looks like a bug.
The logic we had determined with @reakaleek is that in case of multiple values for the same key, the badge should render the latest version specified for the key. So here in this case:

• the ordering of badges is correct (showing serverless first, then stack)
• the value shown in the Stack badge is incorrect, it should be Stack | GA 9.2.0 ...

[reakaleek]

Currently it works like this:

Selects the most relevant applicability for display: available versions first (highest version), then closest future version

Source:

docs-builder/src/Elastic.Documentation/AppliesTo/ApplicabilitySelector.cs

Line 13 in 6ee6ad0

/// Selects the most relevant applicability for display: available versions first (highest version), then closest future version

Do we need to change the algorithm?

[theletterf]

Ah! So it's not showing 9.2 because it's not live yet? I should have thought of that 🤦🏻

[florent-leborgne]

Ahah same, I totally forgot about this nice feature :D