Skip to content

Fix clean output directory in generate command, not generateall method #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Fix clean output directory in generate command, not generateall method #1071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/Elastic.Markdown/DocumentationGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,7 @@ public async Task ResolveDirectoryTree(Cancel ctx)
public async Task GenerateAll(Cancel ctx)
{
var generationState = GetPreviousGenerationState();
// always delete output folder on CI
if (!string.IsNullOrEmpty(Environment.GetEnvironmentVariable("GITHUB_ACTIONS")))
DocumentationSet.ClearOutputDirectory();
else if (!Context.SkipMetadata && (Context.Force || generationState == null))
if (!Context.SkipMetadata && (Context.Force || generationState == null))
DocumentationSet.ClearOutputDirectory();

if (CompilationNotNeeded(generationState, out var offendingFiles, out var outputSeenChanges))
Expand Down
5 changes: 5 additions & 0 deletions src/docs-builder/Cli/Commands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,12 @@ public async Task<int> Generate(

if (runningOnCi)
await githubActionsService.SetOutputAsync("skip", "false");

// always delete output folder on CI
var set = new DocumentationSet(context, logger);
if (runningOnCi)
set.ClearOutputDirectory();


if (bool.TryParse(githubActionsService.GetInput("metadata-only"), out var metaValue) && metaValue)
metadataOnly ??= metaValue;
Expand Down
Loading