Skip to content

Prevent dropdown to open when click on active anchor #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025
Merged

Prevent dropdown to open when click on active anchor #1072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
762c4fd
Make sure dropdown is closed on click
reakaleek Apr 10, 2025
e8a291f
Prevent dropdown to open when clicking active element
reakaleek Apr 10, 2025
9177ebc
Prettier
reakaleek Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Elastic.Markdown/Assets/pages-nav.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@ export function initNav() {
if (!pagesNav) {
return
}

const pagesDropdown = $('#pages-dropdown')
if (pagesDropdown) {
const activeAnchor = $('a.pages-dropdown_active', pagesDropdown)
activeAnchor?.addEventListener('mousedown', (e) => {
e.preventDefault()
})
}

const allNavItems = $$('a', pagesNav)
allNavItems.forEach((link) => {
link.addEventListener('click', () => {
Expand Down
8 changes: 4 additions & 4 deletions src/Elastic.Markdown/Slices/Layout/_TocTree.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@
@if (Model.IsPrimaryNavEnabled && current is { Group.Index: not null })
{
<div class="sticky top-0 py-6 bg-white z-10 border-b-1 border-grey-20 pr-4">
<div class="block group border-1 border-grey-20 rounded-sm font-sans relative">
<div id="pages-dropdown" class="block group border-1 border-grey-20 rounded-sm font-sans relative">
<button class="w-full text-left grid grid-cols-[1fr_auto] cursor-pointer font-semibold gap-1 hover:text-black pl-4 pr-2 py-2 group-open:border-b-1 border-grey-20">
<span>
<div>
<a
class="hover:underline text-blue-elastic hover:text-blue-elastic-100"
class="pages-dropdown_active hover:underline text-blue-elastic hover:text-blue-elastic-100"
href="@current.Group.Index?.Url"
@Htmx.GetNavHxAttributes(true)>
@current.Group.Index?.NavigationTitle
</a>
</span>
</div>
<div class="flex items-center justify-center size-6 hover:bg-grey-20 rounded-sm">
<svg
xmlns="http://www.w3.org/2000/svg"
Expand Down
Loading