Change link-index-updater lambda to react on SQS events #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reakaleek
commented
Apr 28, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the link-index-updater lambda to process SQS events instead of a simple function call, refactoring the bootstrap and handler logic accordingly.
- Updated the lambda bootstrap and handler in Program.cs to use SQS events with a typed response, removing the old string-based handler.
- Introduced a new serializer context in SerializerContext.cs and added new provider classes (LinkReferenceProvider, LinkIndexProvider) to support the new flow.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/infra/docs-lambda-index-publisher/SerializerContext.cs | Adds JSON source generation registrations for SQSEvent, S3EventNotification, and SQSBatchResponse. |
| src/infra/docs-lambda-index-publisher/README.md | Fixes a spelling typo in the build instructions. |
| src/infra/docs-lambda-index-publisher/Program.cs | Refactors the lambda bootstrap to process SQS events and update the link index accordingly. |
| src/infra/docs-lambda-index-publisher/LinkReferenceProvider.cs | Provides logic to retrieve link references from S3, but the cancellation parameter type appears incorrect. |
| src/infra/docs-lambda-index-publisher/LinkIndexProvider.cs | Implements link index update and save logic with optimistic concurrency handling. |
| src/Elastic.Markdown/Links/CrossLinks/CrossLinkResolver.cs | Adds an UpdatedAt property to the link index entry record. |
Files not reviewed (2)
- Directory.Packages.props: Language not supported
- src/infra/docs-lambda-index-publisher/docs-lambda-index-publisher.csproj: Language not supported
Mpdreamz
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.