Refactor domain model out of Elastic.Markdown.csproj #1176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only a first step to isolate components in smaller dedicated libraries.
This allows us to e.g ship smaller AOT compiled lamdba binaries and should make it easier to create dedicated tooling in the future without always having to take a dependency on everything in
Elastic.Markdown. That project really should only hold our authoring components.Also a first step towards a more layered cleaner architecture as we shift out of our first release towards GA.
Again this is not complete by any means some pieces require a bit more work to untangle and create cleaner object dependency graphs.