Skip to content

Assembler match: remove name output #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

Assembler match: remove name output #1288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions actions/assembler-match/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ inputs:
outputs:
content-source-match:
description: 'true/false indicating the branch matches a content-source'
content-source-name:
description: "The name of the content source that matches (current/next) or empty"
content-source-next:
description: "true/false indicating the branch acts as the next content source"
content-source-current:
Expand Down
7 changes: 2 additions & 5 deletions src/tooling/docs-assembler/Cli/ContentSourceCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ public async Task<int> Match([Argument] string? repository = null, [Argument] st
{
logger.LogInformation("'{Repository}' '{BranchOrTag}' combination not found in configuration.", repo, refName);
await githubActionsService.SetOutputAsync("content-source-match", "false");
await githubActionsService.SetOutputAsync("content-source-name", "");
await githubActionsService.SetOutputAsync("content-source-next", "false");
await githubActionsService.SetOutputAsync("content-source-current", "false");
}
else
{
Expand All @@ -71,10 +72,6 @@ public async Task<int> Match([Argument] string? repository = null, [Argument] st
await githubActionsService.SetOutputAsync("content-source-match", "true");
await githubActionsService.SetOutputAsync("content-source-next", matches.Next is not null ? "true" : "false");
await githubActionsService.SetOutputAsync("content-source-current", matches.Current is not null ? "true" : "false");

//TODO remove once we've merged our changes to the github action and its workflow usage to no longer use this output
var name = (matches.Current ?? matches.Next)!.Value.ToStringFast(true);
await githubActionsService.SetOutputAsync("content-source-name", name);
}

await collector.StopAsync(ctx);
Expand Down
Loading