Also write the used link-index to the filesystem and add it as part of the new CheckoutResult record #1316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the new CheckoutResult record
Mpdreamz
requested changes
May 26, 2025
| var builder = new AssemblerBuilder(logger, assembleContext, navigation, htmlWriter, pathProvider, historyMapper); | ||
| await builder.BuildAllAsync(assembleSources.AssembleSets, ctx); | ||
|
|
||
| if (checkoutResult.LinkRegistrySnapshot is { } linkRegistry) |
There was a problem hiding this comment.
Make this a method on AssemblerRepositorySourcer and use the read / write filesystems on AssemblerContext.
That way it will be easier to write tests for this at some point.
Mpdreamz
requested changes
May 27, 2025
src/tooling/docs-assembler/Sourcing/RepositorySourcesFetcher.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
link-index.shapshot.jsonfile to the checkout dir while cloning repositories withclone-allbuild-allcopy thelink-index.snapshot.jsonto the/docsoutput dir.