fix(install): update x64 download link in install script #1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install script currently attempts to download a file named docs-builder-linux-amd64.zip, which does not exist. This results in a broken installation: $ curl -sL https://ela.st/docs-builder-install | sh Note: Installing to /usr/local/bin requires administrator privileges. docs-builder is already installed. Running in non-interactive mode. Proceeding with installation... Downloading docs-builder for linux/amd64... % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 9 100 9 0 0 17 0 --:--:-- --:--:-- --:--:-- 0 Archive: docs-builder-linux-amd64.zip End-of-central-directory signature not found. Either this file is not a zipfile, or it constitutes one disk of a multi-part archive. In the latter case the central directory and zipfile comment will be found on the last disk(s) of this archive. unzip: cannot find zipfile directory in one of docs-builder-linux-amd64.zip or docs-builder-linux-amd64.zip.zip, and cannot find docs-builder-linux-amd64.zip.ZIP, period. Error: Failed to extract docs-builder from docs-builder-linux-amd64.zip. Looking at the releases on github there is no "amd64" release, it was changed at some point to "x64".
theletterf
approved these changes
May 26, 2025
reakaleek
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install script currently attempts to download a file for "amd64", which does not exist. This results in a broken download link on linux/darwin x86_64:
Looking at the releases on github there is no "amd64" release, it was changed at some point to "x64".
The fact that this went unnoticed suggests we don't have active tests for the install script across different systems. Adding such tests would be a good follow up.