Reproducible IDs #1335
Merged
Reproducible IDs #1335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate the ID based on a stable unique attribute
reakaleek
commented
Jun 3, 2025
Comment on lines
-49
to
-53
|
|
||
| /// Used to identify the navigation for the current compilation | ||
| /// We want to reset users sessionStorage every time this changes to invalidate | ||
| /// the guids that no longer exist | ||
| public static string CurrentNavigationId { get; } = Guid.NewGuid().ToString("N")[..8]; |
There was a problem hiding this comment.
I removed this entirely. Since it's original purpose doesn't exist anymore.
(persistent navigation state)
Mpdreamz
approved these changes
Jun 3, 2025
| GroupsInOrder = groups; | ||
| FilesInOrder = files; | ||
| NavigationItems = navigationItems; | ||
| Id = Convert.ToHexString(SHA256.HashData(Encoding.UTF8.GetBytes(FolderName + depth)))[..8]; |
There was a problem hiding this comment.
Not entirely unique, we might want to pass parent folder down the chain to concatenate a /unique/path/to/this/folder
There was a problem hiding this comment.
I'm happy to accept the risk of clashes for now and follow up with another PR.
reakaleek
force-pushed
the
feature/reproducible-ids
branch
from
a061fbe to
830ab85
Compare
SGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the ID based on a stable unique attribute.
This will also help achieve #1334