Skip to content

Forward nested layout sections to global layout #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025
Merged

Forward nested layout sections to global layout #1386

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a654fef
Forward nested layout sections to global layout
Mpdreamz Jun 17, 2025
0ce76c5
Merge branch 'main' into fix/forward-nested-layout-sections
Mpdreamz Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/Elastic.Markdown/Slices/_Layout.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@implements IUsesLayout<Elastic.Documentation.Site._GlobalLayout, GlobalLayoutViewModel>
@functions {
public GlobalLayoutViewModel LayoutModel => Model;
protected override Task ExecuteSectionAsync(string name)
protected override async Task ExecuteSectionAsync(string name)
{
if (name == GlobalSections.Footer && Model.Layout is not LayoutName.Archive)
{
Expand All @@ -19,8 +19,15 @@
</button>
</div>
</aside>
//this ensures we forward footer sections declared in this project into to GlobalLayout view's section
await RenderSectionAsync(GlobalSections.Footer);
}

if (name == GlobalSections.Head)
{
//this ensures we forward head sections declared in this project into to GlobalLayout view's section
await RenderSectionAsync(GlobalSections.Head);
}
return Task.CompletedTask;
}
private async Task RenderDefault()
{
Expand Down
Loading