Skip to content

Fix applies_to rendering #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025
Merged

Fix applies_to rendering #1461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67d63ce
Fix applies_to rendering
reakaleek Jun 26, 2025
884dc57
Only do it for 'Elastic Stack' for now
reakaleek Jun 26, 2025
fe14557
Adjust rendering style
reakaleek Jun 26, 2025
da6ccaa
fix test
reakaleek Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions src/Elastic.Markdown/Myst/Components/ApplicableToComponent.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,32 +145,26 @@

var lifecycleClass = applicability.GetLifeCycleName().ToLowerInvariant().Replace(" ", "-");
<span class="applicable-info" data-tippy-content="@tooltip">
@if (name == "Elastic Stack")
{
@badgeText
}
else
{
@name
}
<span class="applicable-meta applicable-meta-@lifecycleClass">
@if (applicability.Lifecycle != ProductLifecycle.GenerallyAvailable && badgeText == name)
{
<span class="applicable-lifecycle applicable-lifecycle-@lifecycleClass">@applicability.GetLifeCycleName()</span>
}
@if (applicability.Version is not null and not AllVersions)
{
if (name == "Elastic Stack")
{
if (applicability.Version <= currentStackVersion)
@if (name != "Elastic Stack" || applicability.Version <= currentStackVersion)
{
<span class="applicable-version applicable-version-@lifecycleClass">
@applicability.Version
</span>
}
else
{
<span class="applicable-version applicable-version-@lifecycleClass">@applicability.Version</span>
<span class="applicable-lifecycle applicable-lifecycle-@lifecycleClass">
@badgeText
</span>
}
}
else
{
<span class="applicable-version applicable-version-@lifecycleClass">@applicability.Version</span>
}
}
</span>
</span>
Expand Down
20 changes: 11 additions & 9 deletions tests/authoring/Inline/AppliesToRole.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,17 @@ This is an inline {applies_to}`stack: preview 9.1` element.
let ``validate HTML: generates link and alt attr`` () =
markdown |> convertsToHtml """
<p>This is an inline
<span class="applies-inline">
<span class="applicable-info" data-tippy-content="We plan to add this functionality in a future update. Plans may change without notice.">
Planned
<span class="applicable-meta applicable-meta-technical-preview">
</span>
</span>
</span>
element.
</p>
<span class="applies-inline">
<span class="applicable-info" data-tippy-content="We plan to add this functionality in a future update. Plans may change without notice.">
Elastic Stack
<span class="applicable-meta applicable-meta-technical-preview">
<span class="applicable-lifecycle applicable-lifecycle-technical-preview">
Planned
</span>
</span>
</span>
</span>
element.</p>
"""


Expand Down
Loading