Skip to content

Remove ProductLifecycle.Deprecated from deprecated list #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025
Merged

Remove ProductLifecycle.Deprecated from deprecated list #1462

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4d1d73
Remove ProductLifecycle.Deperecated from deprecated list
reakaleek Jun 27, 2025
bfb29f9
Merge branch 'main' into feature/fix-deprecated-hint
reakaleek Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Elastic.Markdown/Myst/FrontMatter/Applicability.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ public static bool TryParse(string? value, IList<(Severity, string)> diagnostics
};

// TODO emit as error when all docs have been updated
if (lifecycle is ProductLifecycle.Planned or ProductLifecycle.Deprecated or ProductLifecycle.Development)
if (lifecycle is ProductLifecycle.Planned or ProductLifecycle.Development)
diagnostics.Add((Severity.Hint, $"The '{lookup}' lifecycle is deprecated and will be removed in a future release."));

var version = tokens.Length < 2
Expand Down
Loading