Use new versions.yml config to render applies_to tags
#1465
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables versioning support for “applies_to” by incorporating a new VersionsConfiguration into the build context and updating lifecycle values across tests, directives, and UI components. Key changes include replacing “discontinued” with “removed” in applicable scenarios, adding several new tests to verify parsing behavior, and updating CLI, assembler, and rendering components to utilize version configuration support.
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/authoring/Framework/Setup.fs | Adds versioning systems to BuildContext; note potential incorrect ID for “eck”. |
| src/Elastic.Markdown/Myst/Roles/RoleParser.cs | Fixes content slice calculation to avoid overrunning the span. |
| Other files | Various updates to tests, CLI commands, components, and documentation reflecting lifecycle value changes and new versioning support. |
reakaleek
force-pushed
the
feature/versioning
branch
from
c3d429a to
464869d
Compare
reakaleek
changed the title
versions.yml config to render applies_to tags
| document.addEventListener('htmx:load', function () { | ||
| document.addEventListener('htmx:load', function (event) { | ||
| console.log('htmx:load') | ||
| console.log(event.detail) |
There was a problem hiding this comment.
Should the logs move up to prod for now?
There was a problem hiding this comment.
woops. thank you!
Will remove it.
|
After meeting with the design team, they already sneak peaked the future design of the applies_to tags.. I will add the design in a follow-up. |
Changes
versions.ymlconfig forapplies_totags.Notes
We were not able to use assembler config because the config needs to be available in isolated builds as well.
Preview
https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/1465/syntax/applies#inline-examples