Skip to content

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Jan 7, 2025

We emit quite a few manual validations during parsing but this should ensure if something happens we didn't for see while parsing yaml in docset.yml or the front matters we:

  1. Recover and continue compilation
  2. Ensure we emit the exception through the regular error collector.
  3. Ensure the error holds the originating file path.

The actual error will still be cryptic (yaml.net is just pretty cryptic) for uncaught exceptions. We'll continue to pre-empt these as we discover them to emit better error messages.

@Mpdreamz Mpdreamz linked an issue Jan 7, 2025 that may be closed by this pull request
@Mpdreamz Mpdreamz merged commit 9d4bd65 into main Jan 7, 2025
3 checks passed
@Mpdreamz Mpdreamz deleted the feature/yaml-parse-error-messages branch January 7, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve docset.yml error messages

1 participant