Skip to content

Optimize preview build permissions #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 7, 2025
Merged

Optimize preview build permissions #1526

merged 4 commits into from
Jul 7, 2025

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Jul 7, 2025 •
edited
Loading

Changes

  • For each job only add the needed permissions following the principle of least privilege.
  • Move the comment logic into it's own job.
  • Move the check files into it's own job so its output can be consumed by the 'build' and 'comment' job.

@reakaleek reakaleek self-assigned this Jul 7, 2025
@reakaleek reakaleek added the automation packaging, ci/cd. label Jul 7, 2025
@reakaleek reakaleek marked this pull request as ready for review July 7, 2025 08:27
@reakaleek reakaleek requested a review from a team as a code owner July 7, 2025 08:27
Mpdreamz
Mpdreamz requested changes Jul 7, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check depend on match?

@reakaleek
Copy link
Member Author

Should check depend on match?

75ff550

@reakaleek reakaleek enabled auto-merge (squash) July 7, 2025 09:03
@reakaleek reakaleek requested a review from Mpdreamz July 7, 2025 09:03
@reakaleek reakaleek merged commit 8c4cbc7 into main Jul 7, 2025
17 checks passed
@reakaleek reakaleek deleted the feature/optimize-preview-build-permissions branch July 7, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees

@reakaleek reakaleek

Labels
automation packaging, ci/cd.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reakaleek @Mpdreamz