Skip to content

Lazyload SearchOrAskAiModal #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2025
Merged

Lazyload SearchOrAskAiModal #1625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c27bf2
Lazyload `SearchOrAskAiModal`
reakaleek Jul 28, 2025
f7ea5bf
Run prettier
reakaleek Jul 28, 2025
b0ed78c
Fix import
reakaleek Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/Elastic.Documentation.Site/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
.parcel-cache/
node_modules/
_static/main.js
_static/main.js.map
_static/custom-elements.js
_static/custom-elements.js.map
_static/pages-nav.js
_static/pages-nav.js.map
_static/styles.css
_static/styles.css.map
_static/*.woff2
_static/*.js
_static/*.js.map
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

long overdue!

29 changes: 26 additions & 3 deletions src/Elastic.Documentation.Site/Assets/web-components/SearchOrAskAi/SearchOrAskAiButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/** @jsxImportSource @emotion/react */
import '../../eui-icons-cache'
import { SearchOrAskAiModal } from './SearchOrAskAiModal'
import { useModalActions, useModalIsOpen } from './modal.store'
import { useSearchActions, useSearchTerm } from './search.store'
import {
Expand All @@ -10,10 +10,18 @@ import {
EuiPanel,
EuiTextTruncate,
EuiText,
EuiLoadingSpinner,
} from '@elastic/eui'
import { css } from '@emotion/react'
import * as React from 'react'
import { useEffect } from 'react'
import { useEffect, Suspense, lazy } from 'react'

// Lazy load the modal component
const SearchOrAskAiModal = lazy(() =>
import('./SearchOrAskAiModal').then((module) => ({
default: module.SearchOrAskAiModal,
}))
)

export const SearchOrAskAiButton = () => {
const searchTerm = useSearchTerm()
Expand All @@ -30,6 +38,13 @@ export const SearchOrAskAiButton = () => {
max-width: 100%;
`

const loadingCss = css`
display: flex;
justify-content: center;
align-items: center;
padding: 2rem;
`

useEffect(() => {
const handleKeydown = (event: KeyboardEvent) => {
if (event.key === 'Escape') {
Expand Down Expand Up @@ -81,7 +96,15 @@ export const SearchOrAskAiButton = () => {
<EuiOverlayMask>
<EuiFocusTrap onClickOutside={closeModal}>
<EuiPanel role="dialog" css={positionCss}>
<SearchOrAskAiModal />
<Suspense
fallback={
<div css={loadingCss}>
<EuiLoadingSpinner size="xl" />
</div>
}
>
<SearchOrAskAiModal />
</Suspense>
</EuiPanel>
</EuiFocusTrap>
</EuiOverlayMask>
Expand Down
10 changes: 2 additions & 8 deletions src/Elastic.Documentation.Site/Assets/web-components/SearchOrAskAi/SearchOrAskAiModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { Suggestions } from './Suggestions'
import { useAskAiTerm, useSearchActions, useSearchTerm } from './search.store'
import {
EuiFieldSearch,
EuiPanel,
EuiSpacer,
EuiBetaBadge,
EuiText,
Expand All @@ -20,12 +19,7 @@ export const SearchOrAskAiModal = () => {
const { setSearchTerm, submitAskAiTerm } = useSearchActions()

return (
<EuiPanel
css={css`
max-height: 80vh;
overflow: hidden;
`}
>
<>
<EuiFieldSearch
fullWidth
placeholder="Search the docs or ask Elastic Docs AI Assistant"
Expand Down Expand Up @@ -61,6 +55,6 @@ export const SearchOrAskAiModal = () => {
This feature is in beta. Got feedback? We'd love to hear it!
</EuiText>
</div>
</EuiPanel>
</>
)
}
Loading