Skip to content

Include proxy only in DEBUG builds not in publish artifacts #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Include proxy only in DEBUG builds not in publish artifacts #1933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/tooling/docs-builder/Http/DocumentationWebHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
using System.Text;
using Documentation.Builder.Diagnostics.LiveMode;
using Elastic.Documentation;
#if DEBUG
using Elastic.Documentation.Api.Infrastructure;
#endif
using Elastic.Documentation.Configuration;
using Elastic.Documentation.ServiceDefaults;
using Elastic.Documentation.Site.FileProviders;
Expand Down Expand Up @@ -42,8 +44,10 @@ IConfigurationContext configurationContext
_writeFileSystem = writeFs;
var builder = WebApplication.CreateSlimBuilder();
_ = builder.AddDocumentationServiceDefaults();

#if DEBUG
builder.Services.AddElasticDocsApiUsecases("dev");
#endif

_ = builder.Logging
.AddFilter("Microsoft.AspNetCore.Hosting.Diagnostics", LogLevel.Error)
.AddFilter("Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware", LogLevel.Error)
Expand Down Expand Up @@ -136,7 +140,9 @@ private void SetUpRoutes()
ServeApiFile(holder, slug, ctx));

var apiV1 = _webApplication.MapGroup("/docs/_api/v1");
#if DEBUG
apiV1.MapElasticDocsApiEndpoints();
#endif

_ = _webApplication.MapGet("{**slug}", (string slug, ReloadableGeneratorState holder, Cancel ctx) =>
ServeDocumentationFile(holder, slug, ctx));
Expand Down
7 changes: 6 additions & 1 deletion src/tooling/docs-builder/Http/StaticWebHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
// See the LICENSE file in the project root for more information

using System.IO.Abstractions;
#if DEBUG
using Elastic.Documentation.Api.Infrastructure;
#endif
using Elastic.Documentation.Configuration;
using Elastic.Documentation.Extensions;
using Elastic.Documentation.ServiceDefaults;
Expand Down Expand Up @@ -35,8 +37,9 @@ public StaticWebHost(int port, string? path)
});

_ = builder.AddDocumentationServiceDefaults();

#if DEBUG
builder.Services.AddElasticDocsApiUsecases("dev");
#endif

_ = builder.Logging
.AddFilter("Microsoft.AspNetCore.Hosting.Diagnostics", LogLevel.Error)
Expand All @@ -63,7 +66,9 @@ private void SetUpRoutes()
_ = WebApplication.MapGet("{**slug}", ServeDocumentationFile);

var apiV1 = WebApplication.MapGroup("/docs/_api/v1");
#if DEBUG
apiV1.MapElasticDocsApiEndpoints();
#endif

}

Expand Down
6 changes: 4 additions & 2 deletions src/tooling/docs-builder/docs-builder.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,12 @@
<PackageReference Include="System.IO.Abstractions.TestingHelpers" />
</ItemGroup>

<ItemGroup>
<ItemGroup Condition="'$(Configuration)' == 'Debug'">
<ProjectReference Include="..\..\api\Elastic.Documentation.Api.Core\Elastic.Documentation.Api.Core.csproj" />
<ProjectReference Include="..\..\api\Elastic.Documentation.Api.Infrastructure\Elastic.Documentation.Api.Infrastructure.csproj" />

</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\Elastic.ApiExplorer\Elastic.ApiExplorer.csproj" />

<ProjectReference Include="..\..\services\Elastic.Documentation.Assembler\Elastic.Documentation.Assembler.csproj" />
Expand Down
Loading