Skip to content

Optional [Argument] mixing with flags not supported by ConsoleAppFramework #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Optional [Argument] mixing with flags not supported by ConsoleAppFramework #1938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tooling/docs-builder/Commands/Assembler/AssemblerIndexCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ ICoreService githubActionsService
/// <summary>
/// Index documentation to Elasticsearch, calls `docs-builder assembler build --exporters elasticsearch`. Exposes more options
/// </summary>
/// <param name="endpoint">Elasticsearch endpoint, alternatively set env DOCUMENTATION_ELASTIC_URL</param>
/// <param name="endpoint">-es, Elasticsearch endpoint, alternatively set env DOCUMENTATION_ELASTIC_URL</param>
/// <param name="environment">The --environment used to clone ends up being part of the index name</param>
/// <param name="apiKey">Elasticsearch API key, alternatively set env DOCUMENTATION_ELASTIC_APIKEY</param>
/// <param name="username">Elasticsearch username (basic auth), alternatively set env DOCUMENTATION_ELASTIC_USERNAME</param>
Expand All @@ -49,7 +49,7 @@ ICoreService githubActionsService
/// <returns></returns>
[Command("")]
public async Task<int> Index(
[Argument] string? endpoint = null,
string? endpoint = null,
string? environment = null,
string? apiKey = null,
string? username = null,
Expand Down
4 changes: 2 additions & 2 deletions src/tooling/docs-builder/Commands/IndexCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ ICoreService githubActionsService
/// <summary>
/// Index a single documentation set to Elasticsearch, calls `docs-builder --exporters elasticsearch`. Exposes more options
/// </summary>
/// <param name="endpoint">Elasticsearch endpoint, alternatively set env DOCUMENTATION_ELASTIC_URL</param>
/// <param name="endpoint">-es, Elasticsearch endpoint, alternatively set env DOCUMENTATION_ELASTIC_URL</param>
/// <param name="path">path to the documentation folder, defaults to pwd.</param>
/// <param name="apiKey">Elasticsearch API key, alternatively set env DOCUMENTATION_ELASTIC_APIKEY</param>
/// <param name="username">Elasticsearch username (basic auth), alternatively set env DOCUMENTATION_ELASTIC_USERNAME</param>
Expand All @@ -47,7 +47,7 @@ ICoreService githubActionsService
/// <returns></returns>
[Command("")]
public async Task<int> Index(
[Argument] string? endpoint = null,
string? endpoint = null,
string? path = null,
string? apiKey = null,
string? username = null,
Expand Down
Loading