Skip to content

Ensure diff validate returns no error if redirects.yml is not found #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Ensure diff validate returns no error if redirects.yml is not found #1940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/authoring/Elastic.Documentation.Refactor/Tracking/LocalChangesService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ public Task<bool> ValidateRedirects(IDiagnosticsCollector collector, string? pat
var redirectFile = new RedirectFile(buildContext);
if (!redirectFile.Source.Exists)
{
collector.EmitError(redirectFile.Source, "File does not exist");
return Task.FromResult(false);
_logger.LogInformation("Redirect file {RedirectFile} does not exist, no redirects to validate.", redirectFile.Source);
return Task.FromResult(true);
}

var redirects = redirectFile.Redirects;
Expand Down
Loading