-
Notifications
You must be signed in to change notification settings - Fork 30
Add :applies_to:
prop to admonitions
#1961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think the styling of the applies switcher is the exception.
Can discuss later though not blocking the pr.
Maybe due to the colored nature of admonitions but I do find the extra information less visible (recognizable might be a better word) than I'd like it to be. |
What would be the expectation for the tooltip or future popover in this case? |
I'm not a UX designer, but my gut tells me that making the badge interactive in admonitions is less problematic than with tabs/dropdowns because the admonition itself is not interactive. |
^^ What @colleenmcginnis said. |
@florent-leborgne @colleenmcginnis @Mpdreamz updated in c652ce6 (including re-enabled tooltip) ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
how would this work for plain admonitions? I find myself creating notes specifically to call out availability (not notes about functionality specific to a version) e.g.:
would maybe work if the admonition could have an "empty" title and put just the badge there, but it wouldn't really read like a title |
@colleenmcginnis perhaps good enough for now? 🤷 |
Changes
:applies_to:
prop handling for adminitionsScreenshot