Skip to content

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Oct 2, 2025

Context

The build did not error in elastic/elasticsearch@4b0dfd1#r2398182955.

Reported by @leemthompo

Changes

  • Remove the resolving logic based on "declared repos".
  • Add test

@reakaleek reakaleek requested a review from a team as a code owner October 2, 2025 12:07
@reakaleek reakaleek requested review from cotti and theletterf October 2, 2025 12:07
@reakaleek reakaleek added the fix label Oct 2, 2025
@reakaleek
Copy link
Member Author

@theletterf I can see the code part that I just removed was introduced in https://github.com/elastic/docs-builder/pull/1615/files#diff-2ae5dfa0b71419475ba9627d282033845c278d67ed966bdfd37ad40b0b0133aaR93-R101

I can see the comment, but can you elaborate on the purpose?

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we have to chase and fix few bad links first before pulling.

@Mpdreamz
Copy link
Member

Mpdreamz commented Oct 2, 2025

content source current and edge:

Error: 'troubleshoot/observability/apm-agent-dotnet/apm-dotnet-agent.md' is not a valid link in the 'docs-content' cross link index: https://elastic-docs-link-index.s3.us-east-2.amazonaws.com/elastic/docs-content/main/links.json
NOTE: /Users/mpdreamz/Projects/docs-builder/.artifacts/checkouts/current/apm-agent-dotnet/docs/docset.yml

content source staging:

Error: 'troubleshoot/observability/apm-agent-dotnet/apm-dotnet-agent.md' is not a valid link in the 'docs-content' cross link index: https://elastic-docs-link-index.s3.us-east-2.amazonaws.com/elastic/docs-content/main/links.json
NOTE: /Users/mpdreamz/Projects/docs-builder/.artifacts/checkouts/next/apm-agent-dotnet/docs/docset.yml

Error: 'reference/edot-android/supported-technologies.md' is not a valid link in the 'apm-agent-android' cross link index: https://elastic-docs-link-index.s3.us-east-2.amazonaws.com/elastic/apm-agent-android/main/links.json

Error: 'reference/elasticsearch/mapping-reference/semantic-tex.md' is not a valid link in the 'elasticsearch' cross link index: https://elastic-docs-link-index.s3.us-east-2.amazonaws.com/elastic/elasticsearch/main/links.json

@Mpdreamz
Copy link
Member

Mpdreamz commented Oct 2, 2025

@theletterf @leemthompo Can you help us address these observability and elasticsearch bad links?

@theletterf
Copy link
Contributor

Sorry, I didn't catch that block during LLM generation. It smells like the typical "let's make this simple" way of Claude of fixing things. Since local builds were catching bad crosslinks and tests were in place, I didn't detect this. My bad.

@reakaleek reakaleek merged commit 863adca into main Oct 2, 2025
48 of 58 checks passed
@reakaleek reakaleek deleted the feature/fix-crosslink-check branch October 2, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants