Skip to content

Conversation

theletterf
Copy link
Contributor

@theletterf theletterf commented Oct 9, 2025

Fixes #1998

Test: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/2026/building-blocks/


This PR was entirely authored using Claude CLI with Claude 4.5 with some direct human intervention.

@theletterf theletterf self-assigned this Oct 9, 2025
@theletterf theletterf requested a review from a team as a code owner October 9, 2025 09:22
@theletterf theletterf requested a review from reakaleek October 9, 2025 09:22
@theletterf
Copy link
Contributor Author

theletterf commented Oct 9, 2025

@reakaleek
Copy link
Member

The padding looks off to me. There is much more padding on the right side.
also the color looks too light IMO.

@theletterf
Copy link
Contributor Author

@reakaleek How about now?

Screenshot 2025-10-09 at 11 29 52

@reakaleek
Copy link
Member

maybe that's bit nitpicky..

but IMO the grey box should align with the top dropdown box.

should it also have the same border radius?

@theletterf
Copy link
Contributor Author

theletterf commented Oct 9, 2025

Using -15px -0px -15px -15px:

Screenshot 2025-10-09 at 11 48 15

@reakaleek how about now?

@Mpdreamz
Copy link
Member

Mpdreamz commented Oct 9, 2025

Can we create an inner box on hover of each item (white)? that stays active when selected?

Thank you for this PR @theletterf!

@Mpdreamz
Copy link
Member

Mpdreamz commented Oct 9, 2025

I think grey-10 looks slightly better:

image

Maybe we can use grey-20 as the hover/active background?

@reakaleek
Copy link
Member

We would need grey-15 😄

@theletterf
Copy link
Contributor Author

theletterf commented Oct 10, 2025

@Mpdreamz @reakaleek Added hover effect!

2025-10-10 10 57 16

@cotti
Copy link
Contributor

cotti commented Oct 10, 2025

General question: Should we have any other kind of highlighting when the user goes further in the navigation tree menu? Or is just the first level there enough?

@theletterf
Copy link
Contributor Author

@cotti Hmm, not sure. Right now the entire section (all parents) get highlighted. I think this is the same behavior as in the old docs. What are you picturing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve left navigation by highlighting active section
4 participants