Skip to content

Add support for gif & jpeg images #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Add support for gif & jpeg images #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11c1b0f
Add support for gif images
Mpdreamz Jan 29, 2025
36052a8
include jpeg support as well
Mpdreamz Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions docs/syntax/images.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,21 @@ Here is the same image used inline ![Elasticsearch](img/observability.png)

Here is the same image used inline ![Elasticsearch](img/observability.png)

### SVG

```markdown
![Elasticsearch](img/alerts.svg)
```
![Elasticsearch](img/alerts.svg)

### GIF

```markdown
![Elasticsearch](img/timeslider.gif)
```
![Elasticsearch](img/timeslider.gif)


## Asciidoc syntax

```asciidoc
Expand Down
62 changes: 62 additions & 0 deletions docs/syntax/img/alerts.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/syntax/img/timeslider.gif
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/Elastic.Markdown/IO/DocumentationSet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ public DocumentationSet(BuildContext context)
.Select(f => context.ReadFileSystem.FileInfo.New(f))
.Select<IFileInfo, DocumentationFile>(file => file.Extension switch
{
".jpg" => new ImageFile(file, SourcePath, "image/jpeg"),
".jpeg" => new ImageFile(file, SourcePath, "image/jpeg"),
".gif" => new ImageFile(file, SourcePath, "image/gif"),
".svg" => new ImageFile(file, SourcePath, "image/svg+xml"),
".png" => new ImageFile(file, SourcePath),
".md" => CreateMarkDownFile(file, context),
Expand Down