Skip to content

Normalize substitution keys to be case-insensitive. #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Normalize substitution keys to be case-insensitive. #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Elastic.Markdown/Myst/ParserContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,18 @@ public ParserContext(
Configuration = configuration;

foreach (var (key, value) in configuration.Substitutions)
Properties[key] = value;
Properties[key.ToLowerInvariant()] = value;

if (frontMatter?.Properties is { } props)
{
foreach (var (key, value) in props)
foreach (var (k, value) in props)
{
var key = k.ToLowerInvariant();
if (configuration.Substitutions.TryGetValue(key, out _))
this.EmitError($"{{{key}}} can not be redeclared in front matter as its a global substitution");
else
Properties[key] = value;
}

}

if (frontMatter?.Title is { } title)
Expand Down
2 changes: 1 addition & 1 deletion src/Elastic.Markdown/Myst/Substitution/SubstitutionParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public override bool Match(InlineProcessor processor, ref StringSlice slice)
startPosition -= openSticks;
startPosition = Math.Max(startPosition, 0);

var key = content.ToString().Trim(['{', '}']);
var key = content.ToString().Trim(['{', '}']).ToLowerInvariant();
var found = false;
var replacement = string.Empty;
if (processor.Context?.Properties.TryGetValue(key, out var value) ?? false)
Expand Down