Skip to content

Fix root links #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 30, 2025
Merged

Fix root links #382

merged 5 commits into from
Jan 30, 2025

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Jan 30, 2025 •
edited
Loading

Context

Absolute links (Rooted links?) to markdown files e.g. /path/to/markdown.md are broken (double slash // between path and prefix) on deployed documentation if the --path-prefix option is set.

Currently,

Changes

Remove the extra /

@reakaleek reakaleek added the fix label Jan 30, 2025
Mpdreamz
Mpdreamz requested changes Jan 30, 2025
View reviewed changes
@reakaleek @Mpdreamz
Update src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlinePa…
bfa6df3 
…rser.cs

Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
@reakaleek reakaleek marked this pull request as ready for review January 30, 2025 15:11
@reakaleek reakaleek requested a review from Mpdreamz January 30, 2025 15:11
@reakaleek reakaleek merged commit 6162b10 into main Jan 30, 2025
5 checks passed
@reakaleek reakaleek deleted the reakaleek-patch-1 branch January 30, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reakaleek @Mpdreamz