Skip to content

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Feb 10, 2025

Changes

Add ability to deploy preview from main/master branch.

Notes

This actually breaks the current PR deployment. But everything will work as expected when it's merged.

@reakaleek reakaleek self-assigned this Feb 10, 2025
@reakaleek reakaleek requested a review from a team February 10, 2025 14:58
@reakaleek reakaleek added the automation packaging, ci/cd. label Feb 10, 2025
Comment on lines +28 to +30
push: <2>
branches:
- main
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25 this is the change needed in elastic/docs-content

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

2. This should be the path to your docs folder.
3. Reusable workflow: [elastic/docs-builder/.github/workflows/preview-build.yml](https://github.com/elastic/docs-builder/blob/main/.github/workflows/preview-build.yml)
2. You can omit the `push` event if you only want to build the docs on PRs.
3. This should be the path to your docs folder.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 and 4 should be swapped?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit?

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🎨

@reakaleek reakaleek enabled auto-merge (squash) February 10, 2025 15:35
@reakaleek reakaleek merged commit 8d0bd66 into main Feb 10, 2025
5 checks passed
@reakaleek reakaleek deleted the feature/deploy-main branch February 10, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation packaging, ci/cd.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants