Rework preview deployment workflows #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reakaleek
force-pushed
the
feature/preview-deploy-rework
branch
from
2c78a79 to
7c9d6ad
Compare
Mpdreamz
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After thinking through the current workflows related to preview builds, I learned that it's worse than using
pull_request_target.In the current way, the
docs-deploy.ymlworkflow deploys every artifact it receives from thedocs-build.ymlworkflow.This means: A bad PR author can modify the
docs-build.ymlworkflow in his own fork and deploy custom HTML pages with malicious JavaScript. (E.g. redirecting to malicious site)Changes
This uses a single workflow for building and deploying the docs and utilizes the
pull_request_targetevent.Since the workflow is running in the context of the main branch, a PR author will not be able to modify the workflow.