Initial support for cross link resolving #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reakaleek
reviewed
Feb 14, 2025
| var dictionary = new Dictionary<string, LinkReference>(); | ||
| foreach (var link in _links) | ||
| { | ||
| var url = $"https://elastic-docs-link-index.s3.us-east-2.amazonaws.com/elastic/{link}/main/links.json"; |
There was a problem hiding this comment.
I think this can be master in some cases
There was a problem hiding this comment.
Aye, that's why we need a links index file that points to all current index files.
reakaleek
reviewed
Feb 14, 2025
| { | ||
| var url = $"https://elastic-docs-link-index.s3.us-east-2.amazonaws.com/elastic/{link}/main/links.json"; | ||
| _logger.LogInformation($"Fetching {url}"); | ||
| var json = await client.GetStringAsync(url); |
There was a problem hiding this comment.
What happens if the url doesn't exit yet?
While we onboard repositories, not all of them might be available from the start.
There was a problem hiding this comment.
For now I'm only going to make docs-content mandatory to resolve.
All others we'll blindly transform to urls for now. (will follow up with another PR to introduce this behavior).
reakaleek
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first stab at it:
All links resolve to:
https://docs-v3-preview.elastic.dev/elastic/<repos>/tree/maincurrently.The index.json file should also list the
currentbranch name so we do not assumemain.