Skip to content

Empty url in markdown links should result in an error not warning #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Empty url in markdown links should result in an error not warning #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc40c6f
Empty url in markdown links should result in an error not warning
Mpdreamz Feb 17, 2025
90e4ca7
fix cherry-pick update test failure
Mpdreamz Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ private bool ValidateBasicUrl(LinkInline link, InlineProcessor processor, string
{
if (string.IsNullOrEmpty(url))
{
processor.EmitWarning(link, "Found empty url");
processor.EmitError(link, "Found empty url");
return false;
}

Expand Down
6 changes: 3 additions & 3 deletions tests/authoring/Inline/InlineLinks.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ type ``inline link with mailto not allowed external host`` () =
let ``has no errors`` () = markdown |> hasNoErrors

[<Fact>]
let ``has warning`` () = markdown |> hasWarning "mailto links should be to elastic.co domains."
let ``has error`` () = markdown |> hasWarning "mailto links should be to elastic.co domains."

type ``empty link should result in an error`` () =

Expand All @@ -54,7 +54,7 @@ type ``empty link should result in an error`` () =
"""

[<Fact>]
let ``should warn`` () = markdown |> hasWarning "Found empty url"
let ``has error`` () = markdown |> hasError "Found empty url"

[<Fact>]
let ``has no erros`` () = markdown |> hasNoErrors
let ``has no warnings`` () = markdown |> hasNoWarnings