Load navigation javascript earlier #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
reviewed
Feb 18, 2025
| import {initTabs} from "./tabs"; | ||
| import {initCopyButton} from "./copybutton"; | ||
|
|
||
| initNav(); |
There was a problem hiding this comment.
should this still be called? I don't see changes to pages-nav.ts
|
Merging this as I am playing with caching the navigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Put the script for the navigation directly under it's DOM element. Hence, it should be loaded and executed before the rest of the content is loaded.
Notes
Not sure if there is an actual performance gain. But I would like to see the effect in elastic/docs-content