Control allow index per environment, default to false #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds environment-specific control for indexing by introducing a new configuration property, "allow_index", that defaults to false.
- Adds a new AllowIndexing property in the AssemblyConfiguration record
- Updates the assembler YAML configuration for production with allow_index
- Propagates the new AllowIndexing setting in the AssemblerBuilder during build
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/docs-assembler/Configuration/AssemblyConfiguration.cs | Introduces new AllowIndexing property with a YAML alias for indexing configuration |
| src/docs-assembler/assembler.yml | Adds "allow_index: false" entry to production environment |
| src/docs-assembler/Building/AssemblerBuilder.cs | Uses the new AllowIndexing property from the environment |
bmorelli25
approved these changes
Mar 14, 2025
reakaleek
reviewed
Mar 14, 2025
reakaleek
reviewed
Mar 14, 2025
reakaleek
approved these changes
Mar 14, 2025
Co-authored-by: Jan Calanog <jan.calanog@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.