Skip to content

Typography adjustments #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

Typography adjustments #747

merged 1 commit into from
Mar 14, 2025

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Mar 14, 2025 •
edited
Loading

  • Remove all letter spacing
  • Use Mier B for headings where missing

cc @sunnyelastic

@Copilot Copilot AI review requested due to automatic review settings March 14, 2025 17:25
@reakaleek reakaleek requested a review from a team as a code owner March 14, 2025 17:25
Copilot
Copilot AI reviewed Mar 14, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies typography adjustments to improve consistency across the site’s layout.

  • Adds the "font-sans" CSS class to several heading elements in the landing page.
  • Removes the tracking class from breadcrumb list items.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/Elastic.Markdown/Slices/Layout/_LandingPage.cshtml Updated heading elements to include "font-sans" and removed the tracking style from one heading for a cleaner look.
src/Elastic.Markdown/Slices/Layout/_Breadcrumbs.cshtml Removed tracking classes from list item elements to align with the updated typography.

@reakaleek reakaleek self-assigned this Mar 14, 2025
@reakaleek reakaleek added the fix label Mar 14, 2025
@reakaleek reakaleek merged commit 9e3e343 into main Mar 14, 2025
8 of 9 checks passed
@reakaleek reakaleek deleted the feature/design-adjustments branch March 14, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Mpdreamz Mpdreamz Mpdreamz approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees

@reakaleek reakaleek

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reakaleek @Mpdreamz @bmorelli25