Skip to content

Conversation

reakaleek
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings March 14, 2025 23:46
@reakaleek reakaleek requested a review from a team as a code owner March 14, 2025 23:46
@reakaleek reakaleek self-assigned this Mar 14, 2025
@reakaleek reakaleek added the fix label Mar 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the landing page layout and button styling to align with the latest design adjustments.

  • Adjusted grid breakpoint from lg to md for responsive layouts
  • Updated button styling including background hover, focus rings, and padding changes
Comments suppressed due to low confidence (6)

src/Elastic.Markdown/Slices/Layout/_LandingPage.cshtml:10

  • Confirm that changing the breakpoint from 'lg:grid-cols-2' to 'md:grid-cols-2' is intentional to achieve the desired layout across devices.
        <div class="container mx-auto py-16 grid md:grid-cols-2 items-center gap-6">

src/Elastic.Markdown/Slices/Layout/_LandingPage.cshtml:15

  • Ensure that reducing the vertical padding from 'py-2.5' to 'py-2' and modifying focus ring colors meets the intended design and accessibility standards.
                    <a href="@Model.Link("/get-started")" class="grow select-none cursor-pointer text-white text-nowrap bg-blue-elastic hover:bg-blue-elastic-110 focus:ring-4 focus:ring-blue-elastic-50 font-semibold font-sans rounded-sm px-6 py-2 focus:outline-none h-10 flex items-center justify-center">

src/Elastic.Markdown/Slices/Layout/_LandingPage.cshtml:276

  • Verify that the updated padding and focus styling on the release notes button are consistent with the overall design language.
                        <a href="@Model.Link("/release-notes/")" class="grow select-none cursor-pointer text-white text-nowrap bg-blue-elastic hover:bg-blue-elastic-110 focus:ring-4 focus:ring-blue-elastic-50 font-semibold font-sans rounded-sm px-6 py-2 focus:outline-none h-10 flex items-center justify-center">

src/Elastic.Markdown/Slices/Layout/_LandingPage.cshtml:292

  • Verify that the styling adjustments for the troubleshooting link button align with the intended design adjustments.
                        <a href="@Model.Link("/troubleshoot/")" class="grow select-none cursor-pointer text-white text-nowrap bg-blue-elastic hover:bg-blue-elastic-110 focus:ring-4 focus:ring-blue-elastic-50 font-semibold font-sans rounded-sm px-6 py-2 focus:outline-none h-10 flex items-center justify-center">

src/Elastic.Markdown/Slices/Layout/_LandingPage.cshtml:308

  • Ensure that the revised styling for the contributing button, including the focus ring color and padding, remains consistent with other similar components.
                        <a href="https://docs-v3-preview.elastic.dev/elastic/asciidocalypse/tree/main/kibana/docs/extend/" class="grow select-none cursor-pointer text-white text-nowrap bg-blue-elastic hover:bg-blue-elastic-110 focus:ring-4 focus:ring-blue-elastic-50 font-semibold font-sans rounded-sm px-6 py-2 focus:outline-none h-10 flex items-center justify-center">

src/Elastic.Markdown/Slices/Layout/_LandingPage.cshtml:355

  • Double-check that updating the focus ring color to 'focus:ring-blue-elastic-50' for the 'Join now' link meets the intended visual and accessibility guidelines.
                <a href="https://discuss.elastic.co" target="_blank" rel="noopener noreferrer" class="grow cursor-pointer text-blue-elastic hover:text-blue-elastic-100 text-nowrap border-2 border-blue-elastic hover:border-blue-elastic-100 focus:ring-4 focus:outline-none focus:ring-blue-elastic-50 font-semibold rounded-sm px-6 py-2 text-center h-10 flex items-center justify-center">

@reakaleek reakaleek enabled auto-merge (squash) March 14, 2025 23:48
@reakaleek reakaleek merged commit 0475050 into main Mar 15, 2025
8 of 9 checks passed
@reakaleek reakaleek deleted the feature/landig-page-adjustments-pt2 branch March 15, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants