Skip to content

Fix table of contents progress indicator #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2025
+18 −16
Merged

Fix table of contents progress indicator #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1e8b12
Fix table of contents progress indicator
reakaleek Mar 15, 2025
ebbb539
Update src/Elastic.Markdown/Assets/toc-nav.ts
reakaleek Mar 15, 2025
36188e4
Merge branch 'main' into feature/fix-table-of-contents-indicator
reakaleek Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Elastic.Markdown/Assets/toc-nav.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ interface TocElements {
const HEADING_OFFSET = 34 * 4;

function initializeTocElements(): TocElements {
const headings = $$('h2, h3');
const headings = $$('#markdown-content h2, #markdown-content h3');
const tocLinks = $$('#toc-nav li>a') as HTMLAnchorElement[];
const tocContainer = $('#toc-nav ul') as HTMLUListElement;
const tocContainer = $('#toc-nav .toc-progress-container') as HTMLDivElement;
const progressIndicator = $('.toc-progress-indicator', tocContainer) as HTMLDivElement;
return { headings, tocLinks, tocContainer,progressIndicator };
return { headings, tocLinks, tocContainer, progressIndicator };
}

// Find the current TOC links based on visible headings
Expand Down
28 changes: 15 additions & 13 deletions src/Elastic.Markdown/Slices/Layout/_TableOfContents.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,21 @@
{
<div class="mb-4">
<div class="font-bold mb-2">On this page</div>
<ul class="block w-full relative font-body">
<div class="toc-progress-indicator absolute top-0 h-0 left-2 w-[1px] bg-blue-elastic transition-all duration-200 ease-out "></div>
@foreach (var item in Model.PageTocItems)
{
<li class="has-[:hover]:border-l-grey-80 items-center ml-2 pl-4 border-l-1 border-l-grey-20 has-[.current]:border-l-blue-elastic!">
<a
class="sidebar-link inline-block my-1 @(item.Level == 3 ? "ml-4" : string.Empty)"
href="#@item.Slug">
@item.Heading
</a>
</li>
}
</ul>
<div class="relative toc-progress-container font-body">
<div class="toc-progress-indicator absolute top-0 h-0 left-2 w-[1px] bg-blue-elastic transition-all duration-200 ease-out "></div>
<ul class="block w-full">
@foreach (var item in Model.PageTocItems)
{
<li class="has-[:hover]:border-l-grey-80 items-center ml-2 pl-4 border-l-1 border-l-grey-20 has-[.current]:border-l-blue-elastic!">
<a
class="sidebar-link inline-block my-1 @(item.Level == 3 ? "ml-4" : string.Empty)"
href="#@item.Slug">
@item.Heading
</a>
</li>
}
</ul>
</div>
</div>
}
<div class="edit-this-page">
Expand Down