Remove tj-actions usage, eventhough we had it pinned as gitref #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the dependency on tj-actions and refactors command execution logic in the repository sourcing code while updating the conditions in the preview build workflow.
- Refactored usage of Exec(), ExecIn(), and related command execution methods in RepositorySourcesFetcher.cs
- Removed the tj-actions/changed-files step and simplified conditional checks in the preview-build workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/docs-assembler/Sourcing/RepositorySourcesFetcher.cs | Updated Exec and ExecIn APIs by removing the redundant "name" parameter and switching to ExecArguments and Proc.Exec |
| .github/workflows/preview-build.yml | Eliminated tj-actions/changed-files usage and simplified conditions for checkout, deployment, and documentation build steps |
Comments suppressed due to low confidence (2)
src/docs-assembler/Sourcing/RepositorySourcesFetcher.cs:136
- The removal of the ConsoleLineHandler from the ExecIn method means that diagnostic logging context previously provided by the 'name' parameter is no longer available. Consider verifying that this change in error reporting and logging detail is intentional, or reintroduce context to assist with debugging.
var result = Proc.Exec(arguments);
.github/workflows/preview-build.yml:61
- With the removal of the changed-files check, the workflow conditions for pull request events have been simplified. Ensure that this change does not lead to unintended triggering of jobs when there are no relevant file changes.
if: startsWith(github.event_name, 'pull_request')
Mpdreamz
commented
Mar 15, 2025
| _logger.LogInformation("Pull: {Name}\t{Repository}\t{RelativePath}", name, repository, relativePath); | ||
| // --allow-unrelated-histories due to shallow clones not finding a common ancestor | ||
| ExecIn(name, checkoutFolder, "git", "pull", "--depth", "1", "--allow-unrelated-histories", "--no-ff"); | ||
| ExecIn(checkoutFolder, "git", "pull", "--depth", "1", "--allow-unrelated-histories", "--no-ff"); |
There was a problem hiding this comment.
unrelated but is a fix for: https://github.com/elastic/docs-internal-workflows/actions/runs/13865451267
reakaleek
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will do a full docs build even for PR's that do not change docs. However because we run reasonably fast the impact is limited.
We do want to restore some checks so we don't always upload to S3 for the preview environment which might take a bit longer.
NOTE: the actions repo itself now 404's (maybe as a precaution by github)