-
Notifications
You must be signed in to change notification settings - Fork 30
Add elastic/detection-rules to assembler navigation.yml #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@colleenmcginnis this now almost works: ![]() The placement in the global navigation is not great but urls resolve and the output paths are in the right place. The urls end up looking like: |
I wonder if security rules should just have an overview page with links instead of injecting 2000 items into the navigation. |
@Mpdreamz I assume you mean making them hidden? if we hide them, then google won't index them either. not sure if we want that |
No more that we make Expanding it is a quick way to get lost on the left menu too. |
I think these are questions @jmikell821 needs to answer. |
It might also align better with follow up work @approksiu wants as well: creating a filterable overview page to navigate the rule sets. |
@Mpdreamz is it the long list of rules in the left nav that's causing a problem? I think a landing page with a link to rules is a good compromise for now, but I'll confirm with @approksiu. We did discuss previously creating a filterable view similar to this here: https://elastic.github.io/detection-rules-explorer/ but given our approaching deadline, I don't know if this is feasible right now? |
Yeah once expanded it hard to navigate back to to other sections.
Aye we discussed that we'll revisit this post 9.0 to create a better experience like the |
@Mpdreamz Landing page is a good idea, I agree the long list of rules is a problem. Please let me know how the landing page would look. Thanks! |
@approksiu for the first version it would be a minimal listing page I could potentially group them under some headers if you prefer? if you do what would be the preferred grouping key? |
@Mpdreamz For the first iteration we could use Domain: ____ tag to group them. |
…up with one index in its navigation to dedup
Here's how the cursorful-video-1743163069468.mp4
@colleenmcginnis @approksiu @jmikell821 this is now looking good on my end let me know if you concur. |
Great work @Mpdreamz ! |
Looks good to me! One question:
Are the individual rule pages still set up to be indexed by search engines? |
Yes they are still crawl-able however I just realized they won't be in our |
Adds prebuilt rule docs to
assembler.yml
andnavigation.yml
.With this configuration, I'm getting 58 errors like these:
You should be able to pull down this branch and clone and build to see the full list of errors.