Skip to content

Downgrade xUnit v3 to 1.1.0 #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Downgrade xUnit v3 to 1.1.0 #942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f05ca2f
Downgrage xUnit v3 to 1.1.0
Mpdreamz Apr 2, 2025
89fae8e
Fix skipunless
Mpdreamz Apr 2, 2025
6037809
Fix skipunless
Mpdreamz Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/Elastic.Markdown.Tests/Elastic.Markdown.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0"/>
<PackageReference Include="xunit.v3" Version="2.0.0"/>
<PackageReference Include="xunit.v3" Version="1.1.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.2"/>
<PackageReference Include="GitHubActionsTestLogger" Version="2.4.1" />

Expand Down
2 changes: 1 addition & 1 deletion tests/authoring/authoring.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0"/>
<PackageReference Include="xunit.v3" Version="2.0.0"/>
<PackageReference Include="xunit.v3" Version="1.1.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.2"/>
<PackageReference Include="GitHubActionsTestLogger" Version="2.4.1"/>

Expand Down
7 changes: 6 additions & 1 deletion tests/docs-assembler.Tests/src/docs-assembler.Tests/GlobalNavigationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,12 @@ public class GlobalNavigationPathProviderTests
public GlobalNavigationPathProviderTests()
{
FileSystem = new FileSystem();
CheckoutDirectory = FileSystem.DirectoryInfo.New(
var checkoutDirectory = FileSystem.DirectoryInfo.New(
FileSystem.Path.Combine(Paths.GetSolutionDirectory()!.FullName, ".artifacts", "checkouts")
);
CheckoutDirectory = checkoutDirectory.Exists
? checkoutDirectory.GetDirectories().FirstOrDefault(d => d.Name is "next" or "current") ?? checkoutDirectory
: checkoutDirectory;
Collector = new DiagnosticsCollector([]);
Context = new AssembleContext("dev", Collector, FileSystem, FileSystem, CheckoutDirectory.FullName, null);
}
Expand Down Expand Up @@ -63,6 +66,8 @@ private async Task<AssembleSources> Setup()
[Fact]
public async Task ReadAllPathPrefixes()
{
Assert.SkipUnless(HasCheckouts(), $"Requires local checkout folder: {CheckoutDirectory.FullName}");

await using var collector = new DiagnosticsCollector([]);

var assembleContext = new AssembleContext("dev", collector, new FileSystem(), new FileSystem(), null, null);
Expand Down
2 changes: 1 addition & 1 deletion tests/docs-assembler.Tests/src/docs-assembler.Tests/docs-assembler.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0"/>
<PackageReference Include="xunit.v3" Version="2.0.0"/>
<PackageReference Include="xunit.v3" Version="1.1.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.2"/>
<PackageReference Include="GitHubActionsTestLogger" Version="2.4.1" />

Expand Down
Loading