Add update-link-index-all command #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
requested changes
Apr 4, 2025
| { | ||
| { NarrativeRepository.RepositoryName, assembleContext.Configuration.Narrative } | ||
| }; | ||
| await Parallel.ForEachAsync(repositories, |
There was a problem hiding this comment.
Did you observe this speeding up the build? Just curious since GenerateAll also tries to satisfy all threads with concurrent generation.
| BucketName = bucketName, | ||
| Key = $"elastic/{checkout.Repository.Name}/{checkout.Repository.GetBranch(contentSource)}/links.json", | ||
| ContentBody = content, | ||
| ContentType = MediaTypeNames.Application.Json, |
There was a problem hiding this comment.
ChecksumAlgorithm = SHA256
| [YamlMember(Alias = "skip")] | ||
| public bool Skip { get; set; } | ||
|
|
||
| public string GetBranch(ContentSource contentSource) => contentSource switch |
| MaxDegreeOfParallelism = Environment.ProcessorCount | ||
| }, async (kv, c) => | ||
| { | ||
| var name = kv.Key.Trim(); |
There was a problem hiding this comment.
try/catch the loop method and emit an error over the diagnostics channel.
That way we can still build all the repositories that do validate and update those.
Mpdreamz
requested changes
Apr 4, 2025
Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
Mpdreamz
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up with refactoring into a separate class e.g. LinkIndexService