-
Notifications
You must be signed in to change notification settings - Fork 154
[Observability] Add docs for enhanced logs component #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@weltenwort is this only available in stateful? I'm not seeing the setting in serverless, but I could be looking in the wrong place. |
hm, good question. I don't think we're intentionally hiding it from serverless. let me investigate... |
Ok, TIL there is an allow-list for advanced settings in serverless. The setting to turn on the logs overview is not in there, so it is effectively not available in serverless. @gbamparop do we want to make the tech preview feature flag for the logs overview available or is it intentionally not exposed? |
I may just merge this PR then, and update if/when it goes into serverless. |
sounds reasonable 👍 thanks for catching this |
@weltenwort I don't think that this was intentional. Let's discuss with @LucaWintergerst next week about whether we will keep the advanced setting in Stateful with the work that we're planning next for the logs overview component. If we do then we can add it to Serverless too. |
This PR closes Issue 4888 and adds documentation for the enhanced application logs component, currently in technical preview.