-
Notifications
You must be signed in to change notification settings - Fork 154
Synthetics: Not sure if best place for it #1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synthetics: Not sure if best place for it #1597
Conversation
Thanks for the PR,Philipp! @mdbirnstiehl can you please do an editorial review. I've asked the synthetics team to review for technical accuracy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! I added some suggestions, let me know if there are any questions or think I misunderstood something.
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small nit.
Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We should document the work around to ignore certificates. We should also add a part about how to install the cert properly into the NodeJS container, but I don't know about it.