Skip to content

Conversation

philippkahr
Copy link
Contributor

We should document the work around to ignore certificates. We should also add a part about how to install the cert properly into the NodeJS container, but I don't know about it.

@philippkahr philippkahr requested a review from a team as a code owner June 4, 2025 07:42
@bmorelli25 bmorelli25 requested a review from mdbirnstiehl June 4, 2025 19:50
@bmorelli25
Copy link
Member

Thanks for the PR,Philipp!

@mdbirnstiehl can you please do an editorial review. I've asked the synthetics team to review for technical accuracy.

Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I added some suggestions, let me know if there are any questions or think I misunderstood something.

philippkahr and others added 3 commits June 5, 2025 11:05
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small nit.

Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
@philippkahr philippkahr enabled auto-merge (squash) June 5, 2025 17:50
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@philippkahr philippkahr merged commit f944d22 into main Jun 5, 2025
6 checks passed
@philippkahr philippkahr deleted the philippkahr-patch-cli-synthetics-airgapped-ignore-cert branch June 5, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants