Skip to content

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jul 9, 2025

Fixes #1891 by refreshing nav instructions. These changes are only added to 9.1 and Serverless, so there will be no corresponding 8.19 PR.

Previews

@nastasha-solomon nastasha-solomon self-assigned this Jul 9, 2025
@nastasha-solomon nastasha-solomon added Serverless Improvements and changes to the Serverless Docs v9.1.0 Team:Experience Issues owned by the Experience Docs Team labels Jul 9, 2025
@nastasha-solomon nastasha-solomon marked this pull request as ready for review July 10, 2025 14:25
@nastasha-solomon nastasha-solomon requested review from a team as code owners July 10, 2025 14:25
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, but otherwise LGTM!

Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shainaraskas
Copy link
Collaborator

are these instructions appropriate for 9.0 users as well? we might have to provide a forked path so 9.0 users can still find their way.

@nastasha-solomon
Copy link
Contributor Author

nastasha-solomon commented Jul 10, 2025

@shainaraskas good catch - from the Stack perspective, these changes are only being introduced in 9.1, so the "old" instructions are still relevant to users on 9.0.x.

RE creating a forked path:
I'm a bit hesitant to include both paths in the docs as they'd make for reaallly long and overwhelming instructions. Instead, I'm considering reducing the nav instruction down to "Find < This ML page > in the main menu or use the global search field." I know it's pretty bare bones, but it is the cleaner and more sustainable option in case the nav changes again.

Copy link

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@nastasha-solomon nastasha-solomon merged commit ae5f23e into main Jul 10, 2025
8 checks passed
@nastasha-solomon nastasha-solomon deleted the issue-1891-ml-nav branch July 10, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Serverless Improvements and changes to the Serverless Docs Team:Experience Issues owned by the Experience Docs Team v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Internal]: Update Machine Learning docs to reflect new navigation in Kibana

5 participants