-
Notifications
You must be signed in to change notification settings - Fork 155
Adds an xlink to the toc that points to reconciled page #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@theletterf has confirmed that adding crosslinks to TOCs was tested and ready to use. Thank you, Fabri! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful! one toc labeling suggestion (hypothetically could extend to the target page for clarity)
deploy-manage/toc.yml
Outdated
- file: users-roles/cluster-or-deployment-auth/user-roles.md | ||
children: | ||
- file: users-roles/cluster-or-deployment-auth/built-in-roles.md | ||
- title: "Roles" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to differentiate from creating your own roles
- title: "Roles" | |
- title: "Built-in roles" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @shainaraskas , that's a good point!
Fabrizio was wondering if we should somehow indicate to users that we're going to send them to the Reference section. Something like this maybe? Wdyt?
- title: "Roles" | |
- title: "Built-in roles (Reference)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree with this really. I think the ux of the links should be altered so if it's an xref, it has a little icon or something. you can do it if you want but it isn't sustainable and doesn't look cute
As part of replacing the Elasticsearch Built-in roles page in the Deploy and manage section with its counterpart in the Reference section this PR will retire the existing page in the Deploy and manage section and instead link to the correct, deduplicated page in the Reference section
Relates to #2218 and #2738